Allow use of TurboMail independent of TurboGears.

[alberto@…]

I've made a couple of changes to TurboMail's package structure (hopefully 100% backwards compatible) to allow re-use of the TurboMail in any python app.

Changes made:

• Removed KidMessage from message.py (I've seen in a comment it was planned for next version) since it depends on tg's view engines

• Tweaked Message's constructor so it doesn't fetch encoding from tg's config but accept it as parameter. If not given, will use Message.default_encoding (which ext.tg monkey-patches for backwards compatibility)

• Moved startup.py to turbogears.ext.tg (changedentrypoints and some imports accordingly)

• Modified init.py to check if TG is installed before importing the extension's symbols into the turbomail namespace.

• Removed the turbogears dependency at setup.py and added as "extras_require". TurboMail now only requires stdlib :)

• Applied reindent.py on all .py files (since I sc**ed indentation badly with my 4-tab-spaces editor)

I've minimally tested it in a quickstarted 1.0.2.2 app and everything seems ok.

This patch makes TurboMail TurboGears2-ready! :)

Alberto

[amcgregor]

Is there any way you could try applying this vs. the 2.0.5 branch, then supply an updated patch?

[realuser]

I'll try to redo the patch for trunk this week so I've reassigned it to myself.

One comment before I start:

I'd like to apply reindent.py on all the package to change tabs to 4 spaces and make it pep8 compliant. However, this will break badly any pending patches so I won't proceed just yet. This is probably the biggest reason why my previous patch didn't apply at all so I'd like to "cleanup" before doing anything.

However, if there's any reason why tabs are preferred then I'd just adjust my editor an comply with the project's guidelines. I strongly recommend switching to 4 spaces as recommended by pep8 though...

If I get a green light I'll commit the change.

Alberto

[realuser]

Ok, I've applied reindent.py successfully in my sandbox and tests pass :) There are no pending patches so all I need is to make sure I'll not be breaking anyone's uncommitted changes and that the change in indentation style is really wanted by "management"... ;)

Alberto

[fs]

I'm not sure if someone has the time to apply this patch to the branch 2.x (if yes, I would ack the patch!) but we definitely need it for 3.0. Therefore I change the milestone to 3.0 and Alberto's changes can be used as a reference for further work.

[amcgregor]

I believe the concerns of this patch and ticket have been acceptably resolved in 3.0 trunk.