Ticket #20 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Patch — Incorrectly testing type of additional headers list.

Reported by: fs Owned by: amcgregor
Priority: low Milestone: 2.1
Component: message-class Version: 2.0.4
Keywords: patch Cc:

Description

The documentation for Message.headers is wrong as it says 'headers -- A list of additional headers.'. In turbomail.Message self.headers is set to [] by default but in _process only tuples and dicts are handled.

The patch attached adds a test case for adding headers and changes the documentation to match the actual code.

Attachments

additional_headers.patch (2.4 kB) - added by fs 1 year ago.
additional_headers2.patch (3.4 kB) - added by fs 1 year ago.
I fixed the Message class so now the use of lists is working, too. Apply this patch after applying the first one

Change History

Changed 1 year ago by fs

Changed 1 year ago by fs

I fixed the Message class so now the use of lists is working, too. Apply this patch after applying the first one

Changed 1 year ago by amcgregor

  • status changed from new to closed
  • resolution set to fixed
  • summary changed from Documentation for additional headers to Incorrectly testing type of additional headers list.
  • component changed from documentation to message-class
  • milestone set to 2.0.5

Patches applied as of r31.

Changed 1 year ago by amcgregor

  • keywords patch added
  • summary changed from Incorrectly testing type of additional headers list. to Incorrectly testing type of additional headers list. — Patch

Changed 1 year ago by amcgregor

  • summary changed from Incorrectly testing type of additional headers list. — Patch to Patch — Incorrectly testing type of additional headers list.
Note: See TracTickets for help on using tickets.